From: Pavel Hrdina <phrdina@redhat.com>
Date: Thu, 6 Mar 2025 11:09:22 +0000 (+0100)
Subject: domain_conf: graphics: extract EGL-Headless formatting to separate function
X-Git-Tag: v11.2.0-rc1~243
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e95d362ba71845e84a45cc5b081620fb970d0f7b;p=thirdparty%2Flibvirt.git

domain_conf: graphics: extract EGL-Headless formatting to separate function

virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 702bc13283..85db84c496 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26602,6 +26602,14 @@ virDomainGraphicsDefFormatSpice(virBuffer *attrBuf,
     return 0;
 }
 
+static void
+virDomainGraphicsDefFormatEGLHeadless(virBuffer *childBuf,
+                                      virDomainGraphicsDef *def)
+{
+    virDomainGraphicsDefFormatGL(childBuf, VIR_TRISTATE_BOOL_ABSENT,
+                                 def->data.egl_headless.rendernode);
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26644,9 +26652,9 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_EGL_HEADLESS:
-        virDomainGraphicsDefFormatGL(&childBuf, VIR_TRISTATE_BOOL_ABSENT,
-                                     def->data.egl_headless.rendernode);
+        virDomainGraphicsDefFormatEGLHeadless(&childBuf, def);
         break;
+
     case VIR_DOMAIN_GRAPHICS_TYPE_DBUS:
         if (def->data.dbus.p2p)
             virBufferAddLit(&attrBuf, " p2p='yes'");