From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Thu, 11 Dec 2008 17:39:01 +0000 (+0000)
Subject: - Connection.invalidate() checks for closed status
X-Git-Tag: rel_0_5_0~117
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e98b9361294ab0cd2b336e55284310217c9b6e50;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- Connection.invalidate() checks for closed status
to avoid attribute errors. [ticket:1246]
---

diff --git a/CHANGES b/CHANGES
index a9a9edd991..f0b3b18f12 100644
--- a/CHANGES
+++ b/CHANGES
@@ -113,6 +113,9 @@ CHANGES
       __eq__().  If the object does not implement 
       __eq__() and mutable=True, a deprecation warning
       is raised.
+    
+    - Connection.invalidate() checks for closed status 
+      to avoid attribute errors. [ticket:1246]
       
     - Fixed the import weirdness in sqlalchemy.sql
       to not export __names__ [ticket:1215].
diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py
index 3a0c1af182..df9cfa7295 100644
--- a/lib/sqlalchemy/engine/base.py
+++ b/lib/sqlalchemy/engine/base.py
@@ -623,6 +623,8 @@ class Connection(Connectable):
         operations in a non-transactional state.
 
         """
+        if self.closed:
+            raise exc.InvalidRequestError("This Connection is closed")
 
         if self.__connection.is_valid:
             self.__connection.invalidate(exception)