From: Wouter Wijngaards <wouter@nlnetlabs.nl>
Date: Thu, 23 Apr 2009 14:59:44 +0000 (+0000)
Subject: python lock deadlock on MacOSX.
X-Git-Tag: release-1.3.0~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ea0148caf8e3597667e05b68716a002efe37fdab;p=thirdparty%2Funbound.git

python lock deadlock on MacOSX.


git-svn-id: file:///svn/unbound/trunk@1615 be551aaa-1e26-0410-a405-d3ace91eadb9
---

diff --git a/doc/Changelog b/doc/Changelog
index c68a21937..f57f97443 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -2,6 +2,7 @@
 	- fix for threadsafety in solaris thr_key_create() in tests.
 	- iana portlist updated.
 	- fix pylib test for Darwin.
+	- fix pymod test for Darwin and a python threading bug in pymod init.
 
 21 April 2009: Wouter
 	- fix for build outside sourcedir.
diff --git a/pythonmod/pythonmod.c b/pythonmod/pythonmod.c
index 67e07b2b0..fe19bfa25 100644
--- a/pythonmod/pythonmod.c
+++ b/pythonmod/pythonmod.c
@@ -87,6 +87,8 @@ int pythonmod_init(struct module_env* env, int id)
       SWIG_init();
    }
 
+   PyEval_AcquireLock();
+
    /* Initialize Python */
    PyRun_SimpleString("import sys \n");
    PyRun_SimpleString("sys.path.append('.') \n");
@@ -101,6 +103,7 @@ int pythonmod_init(struct module_env* env, int id)
    if (PyRun_SimpleString("from unboundmodule import *\n") < 0)
    {
       log_err("pythonmod: cannot initialize core module: unboundmodule.py"); 
+      PyEval_ReleaseLock();
       return 0;
    }
 
@@ -108,6 +111,7 @@ int pythonmod_init(struct module_env* env, int id)
    if ((script_py = fopen(pe->fname, "r")) == NULL) 
    {
       log_err("pythonmod: can't open file %s for reading", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
 
@@ -123,6 +127,7 @@ int pythonmod_init(struct module_env* env, int id)
    if (PyRun_SimpleFile(script_py, pe->fname) < 0) 
    {
       log_err("pythonmod: can't parse Python script %s", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
 
@@ -131,25 +136,28 @@ int pythonmod_init(struct module_env* env, int id)
    if ((pe->func_init = PyDict_GetItemString(pe->dict, "init")) == NULL) 
    {
       log_err("pythonmod: function init is missing in %s", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
    if ((pe->func_deinit = PyDict_GetItemString(pe->dict, "deinit")) == NULL) 
    {
       log_err("pythonmod: function deinit is missing in %s", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
    if ((pe->func_operate = PyDict_GetItemString(pe->dict, "operate")) == NULL) 
    {
       log_err("pythonmod: function operate is missing in %s", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
    if ((pe->func_inform = PyDict_GetItemString(pe->dict, "inform_super")) == NULL) 
    {
       log_err("pythonmod: function inform_super is missing in %s", pe->fname);
+      PyEval_ReleaseLock();
       return 0;
    }
 
-   PyEval_AcquireLock();
    py_cfg = SWIG_NewPointerObj((void*) env->cfg, SWIGTYPE_p_config_file, 0);
    res = PyObject_CallFunction(pe->func_init, "iO", id, py_cfg);
    if (PyErr_Occurred()) 
diff --git a/testdata/pymod.tpkg b/testdata/pymod.tpkg
index 7361ffe1c..afce9a6db 100644
Binary files a/testdata/pymod.tpkg and b/testdata/pymod.tpkg differ