From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2015 19:54:27 +0000 (-0700)
Subject: Merge branch 'jk/run-command-capture'
X-Git-Tag: v2.4.0-rc0~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ea1fd481b4e689f143142662a82fb62c9b2efb65;p=thirdparty%2Fgit.git

Merge branch 'jk/run-command-capture'

The run-command interface was easy to abuse and make a pipe for us
to read from the process, wait for the process to finish and then
attempt to read its output, which is a pattern that lead to a
deadlock.  Fix such uses by introducing a helper to do this
correctly (i.e. we need to read first and then wait the process to
finish) and also add code to prevent such abuse in the run-command
helper.

* jk/run-command-capture:
  run-command: forbid using run_command with piped output
  trailer: use capture_command
  submodule: use capture_command
  wt-status: use capture_command
  run-command: introduce capture_command helper
  wt_status: fix signedness mismatch in strbuf_read call
  wt-status: don't flush before running "submodule status"
---

ea1fd481b4e689f143142662a82fb62c9b2efb65