From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Mon, 13 Feb 2023 20:38:38 +0000 (+0000)
Subject: Remove unused clientReplyContext::holdingBuffer (#1272)
X-Git-Tag: SQUID_6_0_1~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ea21def9238252672ca213b2ef2dc49ce67798d0;p=thirdparty%2Fsquid.git

Remove unused clientReplyContext::holdingBuffer (#1272)

The data member has been unused since inception in 2003 commit 4993f57.
The underlying dumb StoreIOBuffer class does not lock/copy anything.
---

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 973e297828..0004137cbc 100644
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -2100,7 +2100,6 @@ clientReplyContext::sendMoreData (StoreIOBuffer result)
         sc->setDelayId(DelayId::DelayClient(http,reply));
 #endif
 
-    holdingBuffer = result;
     processReplyAccess();
     return;
 }
diff --git a/src/client_side_reply.h b/src/client_side_reply.h
index 5e6de08643..68b45715b3 100644
--- a/src/client_side_reply.h
+++ b/src/client_side_reply.h
@@ -99,7 +99,6 @@ private:
     void sendStreamError(StoreIOBuffer const &result);
     void pushStreamData(StoreIOBuffer const &result, char *source);
     clientStreamNode * next() const;
-    StoreIOBuffer holdingBuffer;
     HttpReply *reply;
     void processReplyAccess();
     static ACLCB ProcessReplyAccessResult;