From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 29 May 2024 22:53:24 +0000 (+1200)
Subject: pidl:python: Exception if unconvertable in ConvertObjectToPythonLevel
X-Git-Tag: tdb-1.4.11~506
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ea78a5ce8301ecea3c8901d96944ad06744535e4;p=thirdparty%2Fsamba.git

pidl:python: Exception if unconvertable in ConvertObjectToPythonLevel

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index aafce9603a8..d7ccf8309e8 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -2295,6 +2295,10 @@ sub ConvertObjectToPythonLevel($$$$$$$)
 		}
 		my $conv = $self->ConvertObjectToPythonData($mem_ctx, $l->{DATA_TYPE}, $var_name, $e->{ORIGINAL});
 		$self->pidl("$py_var = $conv;");
+		if ($conv eq "NULL") {
+			$self->pidl("PyErr_SetString(PyExc_NotImplementedError, \"Cannot convert NDR $var_name to Python\");");
+			$self->pidl("$fail");
+		}
 	} elsif ($l->{TYPE} eq "SUBCONTEXT") {
 		$self->ConvertObjectToPythonLevel($mem_ctx, $env, $e, $nl, $var_name, $py_var, $fail, $recurse);
 	} else {