From: drh <>
Date: Tue, 17 Sep 2024 22:57:08 +0000 (+0000)
Subject: Fix harmless static analyzer warning in sqlite3-rsync.
X-Git-Tag: version-3.47.0~109
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eaa50b866075f4c1a19065600e4f1bae059eb505;p=thirdparty%2Fsqlite.git

Fix harmless static analyzer warning in sqlite3-rsync.

FossilOrigin-Name: a63e412b6b2939422ecfa99d91fccb7a9c61e1533bb0db20ff12f3815ef41a2c
---

diff --git a/manifest b/manifest
index a8b806680f..d371868d8a 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Add\sassert()\sstatements\sto\ssome\sof\sthe\ssqlite3_bind()\sAPIs\sthat\shelp\shuman\nreaders\sand\sstatic\sanalyzers,\sboth,\sreason\sabout\sthe\scode\sand\sverify\sthat\sit\nis\smemory\ssafe.
-D 2024-09-17T21:42:04.331
+C Fix\sharmless\sstatic\sanalyzer\swarning\sin\ssqlite3-rsync.
+D 2024-09-17T22:57:08.639
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -2174,7 +2174,7 @@ F tool/speedtest8inst1.c 7ce07da76b5e745783e703a834417d725b7d45fd
 F tool/spellsift.tcl 52b4b04dc4333c7ab024f09d9d66ed6b6f7c6eb00b38497a09f338fa55d40618 x
 F tool/split-sqlite3c.tcl 5aa60643afca558bc732b1444ae81a522326f91e1dc5665b369c54f09e20de60
 F tool/sqldiff.c 847fc8fcfddf5ce4797b7394cad6372f2f5dc17d8186e2ef8fb44d50fae4f44a
-F tool/sqlite3-rsync.c eecb69a732b74da0bc794d13fac620b2290ba0ea75fb7fe849dd4042a0d1aba8
+F tool/sqlite3-rsync.c f4904e012de382a6ffaf67032f684c209c003eb819e3db7999f393550798c53a
 F tool/sqlite3_analyzer.c.in 8da2b08f56eeac331a715036cf707cc20f879f231362be0c22efd682e2b89b4f
 F tool/sqltclsh.c.in 1bcc2e9da58fadf17b0bf6a50e68c1159e602ce057210b655d50bad5aaaef898
 F tool/sqltclsh.tcl 862f4cf1418df5e1315b5db3b5ebe88969e2a784525af5fbf9596592f14ed848
@@ -2213,8 +2213,8 @@ F vsixtest/vsixtest.tcl 6195aba1f12a5e10efc2b8c0009532167be5e301abe5b31385638080
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 6089a90463dcb3ba8e1584cfc5e2528fbc131311c6df7834fb41a5614a8ca9e8
-R 46830b4a478977d1420032e31ad39f0a
+P 97528788145b83a1486dbaf09326ebedbc07bd0b47a57cdff773885b0b984604
+R de863a50ae68edb342391097eaaa3380
 U drh
-Z 952025d1c1886b18ba7650ce5f8e3ddc
+Z d1cb55d24cd7d46dead0c36bd671adaa
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index cead13e93e..d4cf2dec51 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-97528788145b83a1486dbaf09326ebedbc07bd0b47a57cdff773885b0b984604
+a63e412b6b2939422ecfa99d91fccb7a9c61e1533bb0db20ff12f3815ef41a2c
diff --git a/tool/sqlite3-rsync.c b/tool/sqlite3-rsync.c
index 871d4f2a2f..55136a6a7c 100644
--- a/tool/sqlite3-rsync.c
+++ b/tool/sqlite3-rsync.c
@@ -892,7 +892,7 @@ void writeByte(SQLiteRsync *p, int c){
 */
 int readPow2(SQLiteRsync *p){
   int x = readByte(p);
-  if( x>=32 ){
+  if( x<0 || x>=32 ){
     logError(p, "read invalid page size %d\n", x);
     return 0;
   }