From: John Zhao Date: Wed, 20 Feb 2019 02:39:04 +0000 (+0800) Subject: firmware: hardcode the debug message for -ENOENT X-Git-Tag: v5.1-rc1~146^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eac473bce4b73a089880fb164b8badef81f57fbc;p=thirdparty%2Fkernel%2Flinux.git firmware: hardcode the debug message for -ENOENT When no file /path was found, the error code of -ENOENT enumerated in errno-base.h, is returned. Stating clearly that the file was not found is much more useful for debugging, So let's be explicit about that. Signed-off-by: John Zhao Acked-by: Luis Chamberlain Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 8e9213b36e313..7eaaf5ee5ba6b 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv) rc = kernel_read_file_from_path(path, &fw_priv->data, &size, msize, id); if (rc) { - if (rc == -ENOENT) - dev_dbg(device, "loading %s failed with error %d\n", - path, rc); - else + if (rc != -ENOENT) dev_warn(device, "loading %s failed with error %d\n", path, rc); + else + dev_dbg(device, "loading %s failed for no such file or directory.\n", + path); continue; } dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);