From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: Thu, 24 May 2018 22:34:58 +0000 (-0300)
Subject: gdbstub: Prevent fd leakage
X-Git-Tag: v3.0.0-rc0~117^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ead75d84cb076d51357ca0a48a2bbaf75e5466f5;p=thirdparty%2Fqemu.git

gdbstub: Prevent fd leakage

Since 2f652224f7, we now check if socket_set_nodelay() errored,
but forgot to close the socket before reporting an error.

Fixes: Coverity CID 1391290 (RESOURCE_LEAK)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180524223458.5651-1-f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/gdbstub.c b/gdbstub.c
index 6081e719c53..d6ab95006c4 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1842,6 +1842,7 @@ static bool gdb_accept(void)
     /* set short latency */
     if (socket_set_nodelay(fd)) {
         perror("setsockopt");
+        close(fd);
         return false;
     }