From: Noel Power Date: Thu, 19 Dec 2019 18:10:02 +0000 (+0000) Subject: selftest/knownfail.d: Add entries for samba3.unix.whoami X-Git-Tag: ldb-2.2.0~1015 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eafdbba6e1fb6e64d61946e3d00e61524612424b;p=thirdparty%2Fsamba.git selftest/knownfail.d: Add entries for samba3.unix.whoami samba3.unix.whoami depends of posix extensions which currently only work with SMB1. These tests fail with environments nt4_member & ad_member. We currently don't have plans to provide '_smb1' variants of these environments. So in addition to adding the knownfail we add some coverage by running this test with test env ad_dc_smb1. Also we remove the associated entries from skip_smb1_fail Signed-off-by: Noel Power Reviewed-by: Ralph Boehme --- diff --git a/selftest/knownfail.d/smb1-tests b/selftest/knownfail.d/smb1-tests index f11c43934eb..21aab4d639c 100644 --- a/selftest/knownfail.d/smb1-tests +++ b/selftest/knownfail.d/smb1-tests @@ -30,3 +30,10 @@ ^samba3.blackbox.smbclient_s3.NT1.(plain|sign).member_creds.rename_dotdot\((ad_member|nt4_member)\) ^samba3.blackbox.smbclient_s3.NT1.(plain|sign).member_creds.volume\((ad_member|nt4_member)\) ^samba3.blackbox.smbclient_s3.NT1.(plain|sign).member_creds.delete a non empty directory\((ad_member|nt4_member)\) +^samba3.unix.whoami machine account.whoami\(ad_member:local\) +^samba3.unix.whoami.whoami\(nt4_member\) +^samba3.unix.whoami anonymous connection.whoami\(nt4_member\) +^samba3.unix.whoami.whoami\(ad_member\) +^samba3.unix.whoami kerberos connection.whoami\(ad_member\) +^samba3.unix.whoami anonymous connection.whoami\(ad_member\) +^samba3.unix.whoami ntlm user@realm.whoami\(ad_member\) diff --git a/selftest/skip_smb1_fails b/selftest/skip_smb1_fails index 22b14d13025..2c175a9e30d 100644 --- a/selftest/skip_smb1_fails +++ b/selftest/skip_smb1_fails @@ -7,13 +7,6 @@ # b) port the failing test to SMB2 # c) fix the test ^samba3.blackbox.smbclient_basic.NT1\(nt4_dc_schannel\) -^samba3.unix.whoami\(ad_member\) -^samba3.unix.whoami anonymous connection\(ad_member\) -^samba3.unix.whoami anonymous connection\(nt4_member\) -^samba3.unix.whoami kerberos connection\(ad_member\) -^samba3.unix.whoami machine account\(ad_member:local\) -^samba3.unix.whoami\(nt4_member\) -^samba3.unix.whoami ntlm user@realm\(ad_member\) ^samba4.blackbox.smbclient\(ad_member:local\)\(ad_member:local\) ^samba4.blackbox.smbclient\(chgdcpass:local\)\(chgdcpass:local\) ^samba4.smb.signing disabled on with -k no --option=gensec:spengo=no --signing=off domain-creds\(ad_member\) diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py index df984531e7c..be1342988f9 100755 --- a/source3/selftest/tests.py +++ b/source3/selftest/tests.py @@ -587,7 +587,9 @@ for t in tests: plansmbtorture4testsuite(t, "ad_member:local", '//$SERVER/tmp --realm=$REALM --machine-pass --option=torture:addc=$DC_SERVER', description="machine account") elif t == "unix.whoami": plansmbtorture4testsuite(t, "nt4_member:local", '//$SERVER/tmp --machine-pass', description="machine account") + plansmbtorture4testsuite(t, "ad_dc_smb1:local", '//$SERVER/tmp --machine-pass', description="machine account") plansmbtorture4testsuite(t, "ad_member:local", '//$SERVER/tmp --machine-pass --option=torture:addc=$DC_SERVER', description="machine account") + plansmbtorture4testsuite(t, "ad_dc_smb1:local", '//$SERVER/tmp --machine-pass --option=torture:addc=$DC_SERVER', description="machine account") for env in ["nt4_dc_smb1", "nt4_member"]: plansmbtorture4testsuite(t, env, '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD') plansmbtorture4testsuite(t, env, '//$SERVER/tmpguest -U%', description='anonymous connection')