From: Phil Sutter <phil@nwl.cc>
Date: Thu, 29 Sep 2022 17:11:55 +0000 (+0200)
Subject: extensions: among: Remove pointless fall through
X-Git-Tag: v1.8.9~106
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eafe731a50058ed59305ee4ab1ea2d63d6c4e86e;p=thirdparty%2Fiptables.git

extensions: among: Remove pointless fall through

This seems to be a leftover from an earlier version of the switch().
This fall through is never effective as the next case's code will never
apply. So just break instead.

Fixes: 26753888720d8 ("nft: bridge: Rudimental among extension support")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/extensions/libebt_among.c b/extensions/libebt_among.c
index 7eb898f9..c607a775 100644
--- a/extensions/libebt_among.c
+++ b/extensions/libebt_among.c
@@ -152,10 +152,9 @@ static int bramong_parse(int c, char **argv, int invert,
 			xtables_error(PARAMETER_PROBLEM,
 				      "File should only contain one line");
 		optarg[flen-1] = '\0';
-		/* fall through */
+		break;
 	case AMONG_DST:
-		if (c == AMONG_DST)
-			dst = true;
+		dst = true;
 		/* fall through */
 	case AMONG_SRC:
 		break;