From: rousskov <>
Date: Wed, 23 Jan 2008 03:54:28 +0000 (+0000)
Subject: Bug 2168 fix: Avoid tcp_outgoing_address selection for ICAP requests.
X-Git-Tag: BASIC_TPROXY4~158
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eb03221ca2541231d14de80ec22324f32b1c8d30;p=thirdparty%2Fsquid.git

Bug 2168 fix: Avoid tcp_outgoing_address selection for ICAP requests.
Let OS pick the outgoing (i.e., source) address instead.

Code did not supply info required for tcp_outgoing_address ACL match to work,
and tcp_outgoing_address is usually not applicable to ICAP communication.
Eventually, we may add icap_outgoing_address.
---

diff --git a/src/ICAP/ICAPXaction.cc b/src/ICAP/ICAPXaction.cc
index 7c4a16a3e3..a620b0211c 100644
--- a/src/ICAP/ICAPXaction.cc
+++ b/src/ICAP/ICAPXaction.cc
@@ -125,7 +125,8 @@ void ICAPXaction::openConnection()
 
     disableRetries(); // we only retry pconn failures
 
-    IPAddress outgoing(getOutgoingAddr(NULL));
+    IPAddress outgoing;
+    outgoing.SetAnyAddr();
     connection = comm_open(SOCK_STREAM, 0, outgoing, 
         COMM_NONBLOCKING, s.uri.buf());