From: Dan Carpenter Date: Fri, 28 Feb 2025 09:36:42 +0000 (+0300) Subject: iio: adc: ad4851: Fix signedness bug in ad4851_calibrate() X-Git-Tag: v6.15-rc1~78^2~8^2~39 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eb2f9ab1f5133e5a16e3f6303464f5c60012aa05;p=thirdparty%2Fkernel%2Flinux.git iio: adc: ad4851: Fix signedness bug in ad4851_calibrate() The "c" variable is used to store error codes from ad4851_find_opt() so it has to be signed for the error handling to work. Change it to type int. Fixes: 6250803fe2ec ("iio: adc: ad4851: add ad485x driver") Signed-off-by: Dan Carpenter Reviewed-by: Nuno Sá Link: https://patch.msgid.link/f5e260e9-d7a8-4dae-b7ea-f1bbb1760e60@stanley.mountain Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/adc/ad4851.c b/drivers/iio/adc/ad4851.c index 1ad37084355eb..98ebc853db796 100644 --- a/drivers/iio/adc/ad4851.c +++ b/drivers/iio/adc/ad4851.c @@ -492,11 +492,11 @@ static int ad4851_find_opt(const unsigned long *field, unsigned int start, static int ad4851_calibrate(struct iio_dev *indio_dev) { struct ad4851_state *st = iio_priv(indio_dev); - unsigned int opt_delay, num_lanes, delay, i, s, c; + unsigned int opt_delay, num_lanes, delay, i, s; enum iio_backend_interface_type interface_type; DECLARE_BITMAP(pn_status, AD4851_MAX_LANES * AD4851_MAX_IODELAY); bool status; - int ret; + int c, ret; ret = iio_backend_interface_type_get(st->back, &interface_type); if (ret)