From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 21 Mar 2024 13:46:29 +0000 (+0100)
Subject: vsh: Allow non-interactive use of 'cd' command
X-Git-Tag: v10.3.0-rc1~85
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eb82c632e3b39cf53c2df000020973ea77edbb83;p=thirdparty%2Flibvirt.git

vsh: Allow non-interactive use of 'cd' command

For testing purposes it will come handy to change the directory from a
batch-mode script. Remove the check forbidding use of the 'cd' command
in batch mode.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 37c63f5962..fa038e4547 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -326,8 +326,6 @@ Will change current directory to *directory*.  The default directory
 for the ``cd`` command is the home directory or, if there is no *HOME*
 variable in the environment, the root directory.
 
-This command is only available in interactive mode.
-
 
 pwd
 ---
diff --git a/tools/vsh.c b/tools/vsh.c
index 7305160ed9..2805574ec6 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -3207,11 +3207,6 @@ cmdCd(vshControl *ctl, const vshCmd *cmd)
     const char *dir = NULL;
     g_autofree char *dir_malloced = NULL;
 
-    if (!ctl->imode) {
-        vshError(ctl, "%s", _("cd: command valid only in interactive mode"));
-        return false;
-    }
-
     if (vshCommandOptStringQuiet(ctl, cmd, "dir", &dir) <= 0)
         dir = dir_malloced = virGetUserDirectory();
     if (!dir)