From: bkuhls <bkuhls@users.noreply.github.com>
Date: Sun, 26 Nov 2023 15:09:21 +0000 (+0000)
Subject: Bug 5328: Fix ESI build with libxml2 v2.12.0 (#1600)
X-Git-Tag: SQUID_7_0_1~274
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eb8de6563b8e809149d0673e493d2261ca294b27;p=thirdparty%2Fsquid.git

Bug 5328: Fix ESI build with libxml2 v2.12.0 (#1600)

    Libxml2Parser.cc:147:40: error: invalid conversion from
    'const xmlError*' to 'xmlErrorPtr' {aka 'xmlError*'} [-fpermissive]

libxml2 recently made xmlGetLastError() return a constant object.
---

diff --git a/src/esi/Libxml2Parser.cc b/src/esi/Libxml2Parser.cc
index f037528851..236a37433c 100644
--- a/src/esi/Libxml2Parser.cc
+++ b/src/esi/Libxml2Parser.cc
@@ -144,7 +144,7 @@ ESILibxml2Parser::lineNumber() const
 char const *
 ESILibxml2Parser::errorString() const
 {
-    xmlErrorPtr error = xmlGetLastError();
+    const auto error = xmlGetLastError();
 
     if (error == nullptr)
         return nullptr;