From: Brandon Belew Date: Sun, 9 Mar 2025 04:15:07 +0000 (+0400) Subject: Fix segfault if target_fileio_read_alloc fails X-Git-Tag: gdb-16.3-release~51 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ebb9d77f35402b6f2743a908bd05eb6dd25ee40c;p=thirdparty%2Fbinutils-gdb.git Fix segfault if target_fileio_read_alloc fails Check for target_fileio_read_alloc failure in linux_fill_prpsinfo before dereferencing buffer. This fixes a segfault in the 'gcore' command when attached to certain remote targets. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32441 Approved-By: Andrew Burgess (cherry picked from commit cbc6950a6603e184ebc6671f2c252a56013b07c2) --- diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index d3ab02d03e0..735d20dc050 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -854,7 +854,7 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, { xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", pid); gdb_byte *buffer; - ssize_t len = target_fileio_read_alloc (NULL, filename, &buffer); + LONGEST len = target_fileio_read_alloc (nullptr, filename, &buffer); if (len > 0) { @@ -2180,17 +2180,17 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p) /* The number of fields read by `sscanf'. */ int n_fields = 0; - gdb_assert (p != NULL); + gdb_assert (p != nullptr); /* Obtaining PID and filename. */ pid = inferior_ptid.pid (); xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid); /* The full name of the program which generated the corefile. */ - gdb_byte *buf = NULL; - size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf); + gdb_byte *buf = nullptr; + LONGEST buf_len = target_fileio_read_alloc (nullptr, filename, &buf); gdb::unique_xmalloc_ptr fname ((char *)buf); - if (buf_len < 1 || fname.get ()[0] == '\0') + if (buf_len < 1 || fname.get () == nullptr || fname.get ()[0] == '\0') { /* No program name was read, so we won't be able to retrieve more information about the process. */