From: Topi Miettinen <toiwoton@gmail.com>
Date: Thu, 2 Jan 2020 17:59:48 +0000 (+0200)
Subject: dbus-execute: avoid extra strdup()
X-Git-Tag: v245-rc1~194
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec04aef44225ab0b833b427b43ce8ab69385716d;p=thirdparty%2Fsystemd.git

dbus-execute: avoid extra strdup()

bind_mount_add does the strdup(), so we can avoid
strdup()ing the strings.
---

diff --git a/src/core/dbus-execute.c b/src/core/dbus-execute.c
index 1d0bc1ede3c..c6772ba8431 100644
--- a/src/core/dbus-execute.c
+++ b/src/core/dbus-execute.c
@@ -2379,7 +2379,7 @@ int bus_exec_context_set_transient_property(
                 return 1;
 
         } else if (STR_IN_SET(name, "BindPaths", "BindReadOnlyPaths")) {
-                const char *source, *destination;
+                char *source, *destination;
                 int ignore_enoent;
                 uint64_t mount_flags;
                 bool empty = true;
@@ -2400,8 +2400,8 @@ int bus_exec_context_set_transient_property(
                         if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
                                 r = bind_mount_add(&c->bind_mounts, &c->n_bind_mounts,
                                                    &(BindMount) {
-                                                           .source = strdup(source),
-                                                           .destination = strdup(destination),
+                                                           .source = source,
+                                                           .destination = destination,
                                                            .read_only = !!strstr(name, "ReadOnly"),
                                                            .recursive = !!(mount_flags & MS_REC),
                                                            .ignore_enoent = ignore_enoent,