From: Dimitri Fedrau Date: Sun, 18 Feb 2024 07:57:49 +0000 (+0100) Subject: net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init X-Git-Tag: v6.9-rc1~159^2~206^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec2660946a57d35aa5f3b9a71ae0ab81e5cfcb83;p=thirdparty%2Fkernel%2Flinux.git net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init mv88q2xxx_config_init calls genphy_c45_read_pma which is done by mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is also called by the PHY state machine. Let the PHY state machine handle the phydriver ops in their intendend way. Reviewed-by: Andrew Lunn Tested-by: Stefan Eichenberger Signed-off-by: Dimitri Fedrau Link: https://lore.kernel.org/r/20240218075753.18067-13-dima.fedrau@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c index 58aa10d357310..ebcc6b4046fbf 100644 --- a/drivers/net/phy/marvell-88q2xxx.c +++ b/drivers/net/phy/marvell-88q2xxx.c @@ -370,20 +370,13 @@ static int mv88q2xxx_config_aneg(struct phy_device *phydev) static int mv88q2xxx_config_init(struct phy_device *phydev) { - int ret; - /* The 88Q2XXX PHYs do have the extended ability register available, but * register MDIO_PMA_EXTABLE where they should signalize it does not * work according to specification. Therefore, we force it here. */ phydev->pma_extable = MDIO_PMA_EXTABLE_BT1; - /* Read the current PHY configuration */ - ret = genphy_c45_read_pma(phydev); - if (ret) - return ret; - - return mv88q2xxx_config_aneg(phydev); + return 0; } static int mv88q2xxx_get_sqi(struct phy_device *phydev)