From: Garri Djavadyan <garryd@comnet.uz>
Date: Tue, 1 Aug 2017 00:03:18 +0000 (-0600)
Subject: Bug 4648: Squid ignores object revalidation for HTTPS scheme
X-Git-Tag: M-staged-PR71~67
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec4568e300a7e6e2bf555df68354f32f05d11382;p=thirdparty%2Fsquid.git

Bug 4648: Squid ignores object revalidation for HTTPS scheme

Squid skips object revalidation for HTTPS scheme and, hence, does not
honor a reload_into_ims option (among other settings).

TODO: Add an httpLike() method or function to detect all HTTP-like
schemes instead of comparing with AnyP::PROTO_HTTP directly. There are
20+ candidates for similar bugs: git grep '[!=]= AnyP::PROTO_HTTP'.
---

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 875118d220..5abfe917ab 100644
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -670,7 +670,7 @@ clientReplyContext::cacheHit(StoreIOBuffer result)
              */
             http->logType = LOG_TCP_CLIENT_REFRESH_MISS;
             processMiss();
-        } else if (r->url.getScheme() == AnyP::PROTO_HTTP) {
+        } else if (r->url.getScheme() == AnyP::PROTO_HTTP || r->url.getScheme() == AnyP::PROTO_HTTPS) {
             debugs(88, 3, "validate HIT object? YES.");
             /*
              * Object needs to be revalidated