From: Amos Jeffries <squid3@treenet.co.nz>
Date: Mon, 19 Dec 2011 13:18:29 +0000 (-0700)
Subject: Bug 3447: assertion failed: CommCalls.h:150: "dp"
X-Git-Tag: BumpSslServerFirst.take05~12^2~110
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec507dd267b2d161bf1fe353efbb8cb82c06a8e3;p=thirdparty%2Fsquid.git

Bug 3447: assertion failed: CommCalls.h:150: "dp"

Detatch FD/connection close handlers from reliance on commCloseCbParams
some handlers use FdeCbParams and others are possible.

If the callback handler needs FD the call creator must save it in the
params at call construction time.
---

diff --git a/src/comm.cc b/src/comm.cc
index e69b5314b5..908b10a141 100644
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -937,10 +937,6 @@ commCallCloseHandlers(int fd)
         // If call is not canceled schedule it for execution else ignore it
         if (!call->canceled()) {
             debugs(5, 5, "commCallCloseHandlers: ch->handler=" << call);
-            // XXX: this should not be needed. Params can be set by the call creator
-            typedef CommCloseCbParams Params;
-            Params &params = GetCommParams<Params>(call);
-            params.fd = fd;
             ScheduleCallHere(call);
         }
     }