From: René Scharfe <l.s.r@web.de>
Date: Sat, 11 Feb 2017 13:58:44 +0000 (+0100)
Subject: cocci: detect useless free(3) calls
X-Git-Tag: v2.12.0-rc2~9^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec6cd14c7a869b32776c1d3387afc93f369aea62;p=thirdparty%2Fgit.git

cocci: detect useless free(3) calls

Add a semantic patch for removing checks that cause free(3) to only be
called with a NULL pointer, as that must be a programming mistake.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/contrib/coccinelle/free.cocci b/contrib/coccinelle/free.cocci
index e28213161a..c03ba737e5 100644
--- a/contrib/coccinelle/free.cocci
+++ b/contrib/coccinelle/free.cocci
@@ -3,3 +3,9 @@ expression E;
 @@
 - if (E)
   free(E);
+
+@@
+expression E;
+@@
+- if (!E)
+  free(E);