From: Lucas De Marchi Date: Tue, 15 Feb 2022 22:09:14 +0000 (-0800) Subject: libkmod-module: Fix return code for kmod_module_new_from_lookup() X-Git-Tag: v30~29 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ec8818bcfb903c8f6a614a5aa4d1aa231d79308c;p=thirdparty%2Fkmod.git libkmod-module: Fix return code for kmod_module_new_from_lookup() When kmod_module_new_from_lookup() resolves to an alias, `err` will be set to a positive value from the lookup function. Do not return a positive value to follow the behavior when it matches a module name and the documentation. Reviewed-by: Luis Chamberlain --- diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c index 64233397..1b59c3c4 100644 --- a/libkmod/libkmod-module.c +++ b/libkmod/libkmod-module.c @@ -589,8 +589,8 @@ KMOD_EXPORT int kmod_module_new_from_lookup(struct kmod_ctx *ctx, finish: - DBG(ctx, "lookup %s=%d, list=%p\n", alias, err, *list); - return err; + DBG(ctx, "lookup %s matches=%d, list=%p\n", alias, err, *list); + return err > 0 ? 0 : err; fail: DBG(ctx, "Failed to lookup %s\n", alias); kmod_module_unref_list(*list);