From: Daniel P. Berrangé Date: Fri, 6 Dec 2019 14:38:11 +0000 (+0000) Subject: qapi: better document NVMe blockdev @device parameter X-Git-Tag: v5.0.0-rc0~171^2~26 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ecaf647f300d69271c245a67adca9c3a89d9463a;p=thirdparty%2Fqemu.git qapi: better document NVMe blockdev @device parameter Mention that this is a PCI device address & give the format it is expected in. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- diff --git a/qapi/block-core.json b/qapi/block-core.json index 0cf68fea145..fcb52ec24f3 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2963,9 +2963,13 @@ # # Driver specific block device options for the NVMe backend. # -# @device: controller address of the NVMe device. +# @device: PCI controller address of the NVMe device in +# format hhhh:bb:ss.f (host:bus:slot.function) # @namespace: namespace number of the device, starting from 1. # +# Note that the PCI @device must have been unbound from any host +# kernel driver before instructing QEMU to add the blockdev. +# # Since: 2.12 ## { 'struct': 'BlockdevOptionsNVMe',