From: Vincent Bernat <vincent@bernat.ch>
Date: Sat, 19 Oct 2019 19:52:05 +0000 (+0200)
Subject: test: use scapy when sending pcap files
X-Git-Tag: 1.0.5~35^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ece1209a900fc5cbac53daf02032bf912d42d463;p=thirdparty%2Flldpd.git

test: use scapy when sending pcap files
---

diff --git a/tests/integration/test_pcap.py b/tests/integration/test_pcap.py
index c75b0b2e..8e2a3cb6 100644
--- a/tests/integration/test_pcap.py
+++ b/tests/integration/test_pcap.py
@@ -1,72 +1,54 @@
-import pytest
-import socket
-import struct
+import scapy.all
 
 
 def send_pcap(location, interface):
-    """Send a PCAP file to the given interface. It is assumed that all
-    pcap files are little-endian."""
-    with open(location, 'rb') as f:
-        hdr = f.read(24)
-        magic, major, minor, _, _, _, network = struct.unpack("<IHHiIII",
-                                                              hdr)
-        assert(magic == 0xa1b2c3d4)
-        assert(major == 2)
-        assert(minor == 4)
-        assert(network == 1)
-        hdr = f.read(16)
-        _, _, ilen, olen = struct.unpack("<IIII", hdr)
-        assert(ilen == olen)
-        content = f.read(ilen)
-        s = socket.socket(socket.AF_PACKET, socket.SOCK_RAW)
-        s.bind((interface, 0))
-        s.send(content)
+    packets = scapy.all.rdpcap(location)
+    print(packets)
+    scapy.all.sendp(packets, iface=interface)
 
 
-class TestPcapCaptures(object):
-
-    def test_cisco_sg200(self, request, lldpd1, lldpcli, namespaces):
-        with namespaces(2):
-            send_pcap('data/sg200.pcap', 'eth1')
-        with namespaces(1):
-            out = lldpcli("-f", "keyvalue", "show", "neighbors", "details")
-            assert out['lldp.eth0.age'].startswith('0 day, 00:00:')
-            del out['lldp.eth0.age']
-            expected = {
-                "lldp.eth0.via": "LLDP",
-                "lldp.eth0.rid": "1",
-                "lldp.eth0.chassis.mac": "00:35:35:35:35:35",
-                "lldp.eth0.port.ttl": "120",
-                "lldp.eth0.port.ifname": "g1",
-            }
-            if 'Dot3' in request.config.lldpd.features:
-                expected.update({
-                    "lldp.eth0.port.auto-negotiation.supported": "yes",
-                    "lldp.eth0.port.auto-negotiation.enabled": "yes",
-                    "lldp.eth0.port.auto-negotiation.1000Base-T.hd": "no",
-                    "lldp.eth0.port.auto-negotiation.1000Base-T.fd": "yes",
-                    "lldp.eth0.port.auto-negotiation.current": "unknown",
-                })
-            if 'LLDP-MED' in request.config.lldpd.features:
-                expected.update({
-                    "lldp.eth0.lldp-med.device-type":
-                    "Network Connectivity Device",
-                    "lldp.eth0.lldp-med.Capabilities.available": "yes",
-                    "lldp.eth0.lldp-med.Policy.available": "yes",
-                    "lldp.eth0.lldp-med.Location.available": "yes",
-                    "lldp.eth0.lldp-med.MDI/PSE.available": "yes",
-                    "lldp.eth0.lldp-med.Inventory.available": "yes",
-                    "lldp.eth0.lldp-med.Civic address.country": "DE",
-                    "lldp.eth0.lldp-med.Civic address.city": "Berlin",
-                    "lldp.eth0.lldp-med.Civic address.street":
-                    "Karl-Liebknecht-Strase",
-                    "lldp.eth0.lldp-med.Civic address.building": "42",
-                    "lldp.eth0.lldp-med.inventory.hardware": "V02",
-                    "lldp.eth0.lldp-med.inventory.software": "1.0.8.3",
-                    "lldp.eth0.lldp-med.inventory.firmware": "1.0.8.3",
-                    "lldp.eth0.lldp-med.inventory.serial": "XXX11111ZZZ",
-                    "lldp.eth0.lldp-med.inventory.manufacturer": "0xbc00",
-                    "lldp.eth0.lldp-med.inventory.model": "SG 200-08P",
-                    "lldp.eth0.lldp-med.inventory.asset": "1"
-                })
-            assert out == expected
+def test_cisco_sg200(request, lldpd1, lldpcli, namespaces):
+    with namespaces(2):
+        send_pcap('data/sg200.pcap', 'eth1')
+    with namespaces(1):
+        out = lldpcli("-f", "keyvalue", "show", "neighbors", "details")
+        assert out['lldp.eth0.age'].startswith('0 day, 00:00:')
+        del out['lldp.eth0.age']
+        expected = {
+            "lldp.eth0.via": "LLDP",
+            "lldp.eth0.rid": "1",
+            "lldp.eth0.chassis.mac": "00:35:35:35:35:35",
+            "lldp.eth0.port.ttl": "120",
+            "lldp.eth0.port.ifname": "g1",
+        }
+        if 'Dot3' in request.config.lldpd.features:
+            expected.update({
+                "lldp.eth0.port.auto-negotiation.supported": "yes",
+                "lldp.eth0.port.auto-negotiation.enabled": "yes",
+                "lldp.eth0.port.auto-negotiation.1000Base-T.hd": "no",
+                "lldp.eth0.port.auto-negotiation.1000Base-T.fd": "yes",
+                "lldp.eth0.port.auto-negotiation.current": "unknown",
+            })
+        if 'LLDP-MED' in request.config.lldpd.features:
+            expected.update({
+                "lldp.eth0.lldp-med.device-type":
+                "Network Connectivity Device",
+                "lldp.eth0.lldp-med.Capabilities.available": "yes",
+                "lldp.eth0.lldp-med.Policy.available": "yes",
+                "lldp.eth0.lldp-med.Location.available": "yes",
+                "lldp.eth0.lldp-med.MDI/PSE.available": "yes",
+                "lldp.eth0.lldp-med.Inventory.available": "yes",
+                "lldp.eth0.lldp-med.Civic address.country": "DE",
+                "lldp.eth0.lldp-med.Civic address.city": "Berlin",
+                "lldp.eth0.lldp-med.Civic address.street":
+                "Karl-Liebknecht-Strase",
+                "lldp.eth0.lldp-med.Civic address.building": "42",
+                "lldp.eth0.lldp-med.inventory.hardware": "V02",
+                "lldp.eth0.lldp-med.inventory.software": "1.0.8.3",
+                "lldp.eth0.lldp-med.inventory.firmware": "1.0.8.3",
+                "lldp.eth0.lldp-med.inventory.serial": "XXX11111ZZZ",
+                "lldp.eth0.lldp-med.inventory.manufacturer": "0xbc00",
+                "lldp.eth0.lldp-med.inventory.model": "SG 200-08P",
+                "lldp.eth0.lldp-med.inventory.asset": "1"
+            })
+        assert out == expected