From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 11 Dec 2012 18:34:16 +0000 (+0100)
Subject: qemu: Improve error reporting from qemuDomainManagedSaveRemove
X-Git-Tag: v1.0.1-rc2~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ed0bfd04f86eafecbd7ea2959117abc74f5cd9dd;p=thirdparty%2Flibvirt.git

qemu: Improve error reporting from qemuDomainManagedSaveRemove

Report an error if unlink of the managedsave file fails.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 87c5b34258..1228f6ed81 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3337,8 +3337,15 @@ qemuDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags)
     if (!(name = qemuDomainManagedSavePath(driver, vm)))
         goto cleanup;
 
-    ret = unlink(name);
+    if (unlink(name) < 0) {
+        virReportSystemError(errno,
+                             _("Failed to remove managed save file '%s'"),
+                             name);
+        goto cleanup;
+    }
+
     vm->hasManagedSave = false;
+    ret = 0;
 
 cleanup:
     VIR_FREE(name);