From: Willy Tarreau <w@1wt.eu>
Date: Thu, 18 Aug 2022 13:30:41 +0000 (+0200)
Subject: MINOR: mux-h2/traces: report transition to SETTINGS1 before not after
X-Git-Tag: v2.7-dev4~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ed2b9d9f27b8591ff057717dbb2f332220afc83e;p=thirdparty%2Fhaproxy.git

MINOR: mux-h2/traces: report transition to SETTINGS1 before not after

Traces indicating "switching to XXX" generally apply before the transition
so that the current connection state is visible in the trace. SETTINGS1
was incorrect in this regard, with the trace being emitted after. Let's
fix this.

No need to backport this, as this is purely cosmetic.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index f34941caeb..e45e8f916b 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -3312,8 +3312,8 @@ static void h2_process_demux(struct h2c *h2c)
 			TRACE_PROTO("received preface", H2_EV_RX_PREFACE, h2c->conn);
 
 			h2c->max_id = 0;
-			h2c->st0 = H2_CS_SETTINGS1;
 			TRACE_STATE("switching to SETTINGS1", H2_EV_RX_PREFACE, h2c->conn);
+			h2c->st0 = H2_CS_SETTINGS1;
 		}
 
 		if (h2c->st0 == H2_CS_SETTINGS1) {