From: Phil Sutter <phil@nwl.cc>
Date: Thu, 12 Jan 2023 13:38:44 +0000 (+0100)
Subject: extensions: NAT: Fix for -Werror=format-security
X-Git-Tag: v1.8.10~96
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ed4082a7405a5838c205a34c1559e289949200cc;p=thirdparty%2Fiptables.git

extensions: NAT: Fix for -Werror=format-security

Have to pass either a string literal or format string to xt_xlate_add().

Fixes: f30c5edce0413 ("extensions: Merge SNAT, DNAT, REDIRECT and MASQUERADE")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/extensions/libxt_NAT.c b/extensions/libxt_NAT.c
index da9f2201..2a634398 100644
--- a/extensions/libxt_NAT.c
+++ b/extensions/libxt_NAT.c
@@ -424,7 +424,7 @@ __NAT_xlate(struct xt_xlate *xl, const struct nf_nat_range2 *r,
 	if (r->flags & NF_NAT_RANGE_PROTO_OFFSET)
 		return 0;
 
-	xt_xlate_add(xl, tgt);
+	xt_xlate_add(xl, "%s", tgt);
 	if (strlen(range_str))
 		xt_xlate_add(xl, " to %s", range_str);
 	if (r->flags & NF_NAT_RANGE_PROTO_RANDOM) {