From: Christophe JAILLET Date: Sat, 10 Aug 2024 21:39:04 +0000 (+0200) Subject: net: netconsole: Constify struct config_item_type X-Git-Tag: v6.12-rc1~232^2~264 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ed4290f39f417793928630e85c26411db233d841;p=thirdparty%2Fkernel%2Flinux.git net: netconsole: Constify struct config_item_type 'struct config_item_type' is not modified in this driver. This structure is only used with config_group_init_type_name() which takes a const struct config_item_type* as a 3rd argument. This also makes things consistent with 'netconsole_target_type' witch is already const. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 33007 3952 1312 38271 957f drivers/net/netconsole.o After: ===== text data bss dec hex filename 33071 3888 1312 38271 957f drivers/net/netconsole.o Signed-off-by: Christophe JAILLET Reviewed-by: Breno Leitao Link: https://patch.msgid.link/9c205b2b4bdb09fc9e9d2cb2f2936ec053da1b1b.1723325900.git.christophe.jaillet@wanadoo.fr Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 43c29b15adbfa..72384c1ecc5ce 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -825,7 +825,7 @@ static struct configfs_group_operations userdata_ops = { .drop_item = userdatum_drop, }; -static struct config_item_type userdata_type = { +static const struct config_item_type userdata_type = { .ct_item_ops = &userdatum_ops, .ct_group_ops = &userdata_ops, .ct_attrs = userdata_attrs,