From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 21 Mar 2015 15:50:51 +0000 (+0100)
Subject: gtls: add check of return code
X-Git-Tag: curl-7_42_0~108
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ed429b72d7dee4f63f1e1abc10b52e7b0739da82;p=thirdparty%2Fcurl.git

gtls: add check of return code

Coverity CID 1291167 pointed out that 'rc' was received but never used when
gnutls_credentials_set() was used. Added return code check now.
---

diff --git a/lib/vtls/gtls.c b/lib/vtls/gtls.c
index 82c09bc801..3ad0f82ff3 100644
--- a/lib/vtls/gtls.c
+++ b/lib/vtls/gtls.c
@@ -671,13 +671,21 @@ gtls_connect_step1(struct connectdata *conn,
   if(data->set.ssl.authtype == CURL_TLSAUTH_SRP) {
     rc = gnutls_credentials_set(session, GNUTLS_CRD_SRP,
                                 conn->ssl[sockindex].srp_client_cred);
-    if(rc != GNUTLS_E_SUCCESS)
+    if(rc != GNUTLS_E_SUCCESS) {
       failf(data, "gnutls_credentials_set() failed: %s", gnutls_strerror(rc));
+      return CURLE_SSL_CONNECT_ERROR;
+    }
   }
   else
 #endif
+  {
     rc = gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE,
                                 conn->ssl[sockindex].cred);
+    if(rc != GNUTLS_E_SUCCESS) {
+      failf(data, "gnutls_credentials_set() failed: %s", gnutls_strerror(rc));
+      return CURLE_SSL_CONNECT_ERROR;
+    }
+  }
 
   /* set the connection handle (file descriptor for the socket) */
   gnutls_transport_set_ptr(session,