From: George Thessalonikefs <george@nlnetlabs.nl>
Date: Mon, 4 Jul 2022 07:34:45 +0000 (+0200)
Subject: - Fix bug introduced in 'improve val_sigcrypt.c::algo_needs_missing for
X-Git-Tag: release-1.16.1rc1~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eda0c0c194c76f3df05393ce57c503e1f605c733;p=thirdparty%2Funbound.git

- Fix bug introduced in 'improve val_sigcrypt.c::algo_needs_missing for
  one loop pass'.
---

diff --git a/doc/Changelog b/doc/Changelog
index 2441999c7..58c9d4a96 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,7 @@
+4 July 2022: George
+	- Fix bug introduced in 'improve val_sigcrypt.c::algo_needs_missing for
+	  one loop pass'.
+
 3 July 2022: George
 	- Merge PR #671 from Petr Menšík: Disable ED25519 and ED448 in FIPS
 	  mode on openssl3.
diff --git a/validator/val_sigcrypt.c b/validator/val_sigcrypt.c
index 6d62119eb..5ab21e20e 100644
--- a/validator/val_sigcrypt.c
+++ b/validator/val_sigcrypt.c
@@ -517,11 +517,12 @@ int algo_needs_missing(struct algo_needs* n)
 	/* check if a needed algo was bogus - report that;
 	 * check the first missing algo - report that;
 	 * or return 0 */
-	for(i=0; i<ALGO_NEEDS_MAX; i++)
+	for(i=0; i<ALGO_NEEDS_MAX; i++) {
 		if(n->needs[i] == 2)
 			return 0;
 		if(n->needs[i] == 1 && miss == -1)
 			miss = i;
+	}
 	if(miss != -1) return miss;
 	return 0;
 }