From: Karel Zak <kzak@redhat.com>
Date: Thu, 23 May 2019 13:17:16 +0000 (+0200)
Subject: fallocate: make posix_fadvise() use more readable for analyzers
X-Git-Tag: v2.34-rc2~26
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=edf9c218c1d8e1c5068dfe82c3fc723a51099510;p=thirdparty%2Futil-linux.git

fallocate: make posix_fadvise() use more readable for analyzers

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/sys-utils/fallocate.c b/sys-utils/fallocate.c
index 04a3eaff53..15dcbb0a62 100644
--- a/sys-utils/fallocate.c
+++ b/sys-utils/fallocate.c
@@ -219,8 +219,11 @@ static void dig_holes(int fd, off_t file_off, off_t len)
 		if (file_end && end > file_end)
 			end = file_end;
 
+		if (off < 0 || end < 0)
+			break;
+
 #if defined(POSIX_FADV_SEQUENTIAL) && defined(HAVE_POSIX_FADVISE)
-		posix_fadvise(fd, off, end, POSIX_FADV_SEQUENTIAL);
+		(void) posix_fadvise(fd, off, end, POSIX_FADV_SEQUENTIAL);
 #endif
 		/*
 		 * Dig holes in the area
@@ -251,7 +254,7 @@ static void dig_holes(int fd, off_t file_off, off_t len)
 				size_t clen = off - cache_start;
 
 				clen = (clen / cachesz) * cachesz;
-				posix_fadvise(fd, cache_start, clen, POSIX_FADV_DONTNEED);
+				(void) posix_fadvise(fd, cache_start, clen, POSIX_FADV_DONTNEED);
 				cache_start = cache_start + clen;
 			}
 #endif