From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 20 May 2024 20:22:00 +0000 (+0000)
Subject: hook: plug a new memory leak
X-Git-Tag: v2.39.5~1^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee052533bb81aca6f94c0961222bed2a19789dae;p=thirdparty%2Fgit.git

hook: plug a new memory leak

In 8db1e8743c0 (clone: prevent hooks from running during a clone,
2024-03-28), I introduced an inadvertent memory leak that was
unfortunately not caught before v2.45.1 was released. Here is a fix.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/hook.c b/hook.c
index 632b537b99..fc974cee1d 100644
--- a/hook.c
+++ b/hook.c
@@ -18,8 +18,10 @@ static int identical_to_template_hook(const char *name, const char *path)
 		found_template_hook = access(template_path.buf, X_OK) >= 0;
 	}
 #endif
-	if (!found_template_hook)
+	if (!found_template_hook) {
+		strbuf_release(&template_path);
 		return 0;
+	}
 
 	ret = do_files_match(template_path.buf, path);