From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Fri, 19 Nov 2021 14:49:29 +0000 (+0100)
Subject: BUILD: quic: fix potential NULL dereference on xprt_quic
X-Git-Tag: v2.5-dev15~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee72a43321a22719eb06a6fad5240039aeb70b04;p=thirdparty%2Fhaproxy.git

BUILD: quic: fix potential NULL dereference on xprt_quic

A warning is triggered by gcc9 on this code path, which is the compiler
version used by ubuntu20.04 on the github CI.

This is linked to github issue #1445.
---

diff --git a/src/quic_sock.c b/src/quic_sock.c
index a574de0c0d..38a8aab4b5 100644
--- a/src/quic_sock.c
+++ b/src/quic_sock.c
@@ -191,9 +191,9 @@ void quic_sock_fd_iocb(int fd)
 		return;
 
 	rxbuf = MT_LIST_POP(&l->rx.rxbuf_list, typeof(rxbuf), mt_list);
-	buf = &rxbuf->buf;
-	if (!buf)
+	if (!rxbuf)
 		goto out;
+	buf = &rxbuf->buf;
 
 	params = &l->bind_conf->quic_params;
 	max_sz = params->max_udp_payload_size;