From: Rafael J. Wysocki Date: Fri, 4 Oct 2024 19:35:16 +0000 (+0200) Subject: thermal: core: Drop need_update field from struct thermal_zone_device X-Git-Tag: v6.13-rc1~193^2~3^2~30 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee879a5ea33c49d994fc1d2a60a36afe004548ce;p=thirdparty%2Flinux.git thermal: core: Drop need_update field from struct thermal_zone_device After previous changes, the need_update field in struct thermal_zone_device is only set and never read, so drop it. No functional impact. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/2495061.jE0xQCEvom@rjwysocki.net Reviewed-by: Lukasz Luba --- diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index b8c3a9185ae72..13e22fcfad184 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -842,7 +842,6 @@ static int thermal_bind_cdev_to_trip(struct thermal_zone_device *tz, if (!result) { list_add_tail(&dev->tz_node, &tz->thermal_instances); list_add_tail(&dev->cdev_node, &cdev->thermal_instances); - atomic_set(&tz->need_update, 1); thermal_governor_update_tz(tz, THERMAL_TZ_BIND_CDEV); } @@ -1507,9 +1506,6 @@ thermal_zone_device_register_with_trips(const char *type, if (result) goto remove_id; - /* A new thermal zone needs to be updated anyway. */ - atomic_set(&tz->need_update, 1); - result = dev_set_name(&tz->device, "thermal_zone%d", tz->id); if (result) { thermal_zone_destroy_device_groups(tz); diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h index f8d2e85d24081..a28f7198f9176 100644 --- a/drivers/thermal/thermal_core.h +++ b/drivers/thermal/thermal_core.h @@ -96,7 +96,6 @@ struct thermal_governor { trip point. * @prev_high_trip: the above current temperature if you've crossed a passive trip point. - * @need_update: if equals 1, thermal_zone_device_update needs to be invoked. * @ops: operations this &thermal_zone_device supports * @tzp: thermal zone parameters * @governor: pointer to the governor for this thermal zone @@ -130,7 +129,6 @@ struct thermal_zone_device { int passive; int prev_low_trip; int prev_high_trip; - atomic_t need_update; struct thermal_zone_device_ops ops; struct thermal_zone_params *tzp; struct thermal_governor *governor;