From: Florian Westphal Date: Tue, 23 Jan 2024 16:49:33 +0000 (+0100) Subject: extensions: libebt_stp: fix range checking X-Git-Tag: v1.8.11~93 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee87ad419e9a0c66a0b80fd73a530af741d2629e;p=thirdparty%2Fiptables.git extensions: libebt_stp: fix range checking This has to either consider ->nvals > 1 or check the values post-no-range-fixup: ./iptables-test.py extensions/libebt_stp.t extensions/libebt_stp.t: ERROR: line 12 (cannot load: ebtables -A INPUT --stp-root-cost 1) (it tests 0 < 1 and fails, but test should be 1 < 1). Fixes: dc6efcfeac38 ("extensions: libebt_stp: Use guided option parser") Signed-off-by: Florian Westphal Signed-off-by: Phil Sutter --- diff --git a/extensions/libebt_stp.c b/extensions/libebt_stp.c index 81054b26..371fa04c 100644 --- a/extensions/libebt_stp.c +++ b/extensions/libebt_stp.c @@ -142,7 +142,7 @@ static void brstp_parse(struct xt_option_call *cb) #define RANGE_ASSIGN(name, fname, val) { \ stpinfo->config.fname##l = val[0]; \ stpinfo->config.fname##u = cb->nvals > 1 ? val[1] : val[0]; \ - if (val[1] < val[0]) \ + if (stpinfo->config.fname##u < stpinfo->config.fname##l) \ xtables_error(PARAMETER_PROBLEM, \ "Bad --stp-" name " range"); \ }