From: Qiang Ma <maqianga@uniontech.com>
Date: Wed, 17 Jul 2024 07:00:43 +0000 (+0800)
Subject: efi/libstub: Zero initialize heap allocated struct screen_info
X-Git-Tag: v6.11-rc1~44^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee8b8f5d83eb2c9caaebcf633310905ee76856e9;p=thirdparty%2Flinux.git

efi/libstub: Zero initialize heap allocated struct screen_info

After calling uefi interface allocate_pool to apply for memory, we
should clear 0 to prevent the possibility of using random values.

Signed-off-by: Qiang Ma <maqianga@uniontech.com>
Cc: <stable@vger.kernel.org> # v6.6+
Fixes: 732ea9db9d8a ("efi: libstub: Move screen_info handling to common code")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---

diff --git a/drivers/firmware/efi/libstub/screen_info.c b/drivers/firmware/efi/libstub/screen_info.c
index a51ec201ca3cb..5d3a1e32d1776 100644
--- a/drivers/firmware/efi/libstub/screen_info.c
+++ b/drivers/firmware/efi/libstub/screen_info.c
@@ -32,6 +32,8 @@ struct screen_info *__alloc_screen_info(void)
 	if (status != EFI_SUCCESS)
 		return NULL;
 
+	memset(si, 0, sizeof(*si));
+
 	status = efi_bs_call(install_configuration_table,
 			     &screen_info_guid, si);
 	if (status == EFI_SUCCESS)