From: Christoph Hellwig <hch@lst.de>
Date: Mon, 18 Jul 2022 05:00:12 +0000 (+0200)
Subject: nvmet: don't check for NULL pointer before kfree in nvmet_host_release
X-Git-Tag: v6.0-rc1~112^2~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee8cd008b7da0ee6f24167739e364f43b8a0875b;p=thirdparty%2Fkernel%2Flinux.git

nvmet: don't check for NULL pointer before kfree in nvmet_host_release

And add an empty line after the variable declaration.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index e826a22f5e07e..2bcd60758919b 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -1808,9 +1808,9 @@ static struct configfs_attribute *nvmet_host_attrs[] = {
 static void nvmet_host_release(struct config_item *item)
 {
 	struct nvmet_host *host = to_host(item);
+
 #ifdef CONFIG_NVME_TARGET_AUTH
-	if (host->dhchap_secret)
-		kfree(host->dhchap_secret);
+	kfree(host->dhchap_secret);
 #endif
 	kfree(host);
 }