From: Wouter Wijngaards Date: Wed, 3 Jun 2009 08:06:56 +0000 (+0000) Subject: Review comments Matthijs. X-Git-Tag: release-1.3.0^0 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ee8ea8c5c1c302bc3a58d5d43bd860aa9ab56f66;p=thirdparty%2Funbound.git Review comments Matthijs. git-svn-id: file:///svn/unbound/tags/release-1.3.0@1638 be551aaa-1e26-0410-a405-d3ace91eadb9 --- diff --git a/doc/Changelog b/doc/Changelog index 287a583f8..33179f773 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,6 +1,7 @@ 3 June 2009: Wouter - fixup bad free() when wrongly encoded DSA signature is seen. Reported by Paul Wouters. + - review comments from Matthijs. 2 June 2009: Wouter - --enable-sha2 option. The draft rsasha256 changed its algorithm diff --git a/iterator/iterator.c b/iterator/iterator.c index 5e6dc5e17..72d5198eb 100644 --- a/iterator/iterator.c +++ b/iterator/iterator.c @@ -1771,8 +1771,10 @@ processTargetResponse(struct module_qstate* qstate, int id, log_query_info(VERB_ALGO, "processTargetResponse super", &forq->qinfo); /* check to see if parent event is still interested (in orig name). */ - if(!foriq->dp) + if(!foriq->dp) { + verbose(VERB_ALGO, "subq: parent not interested, was reset"); return; /* not interested anymore */ + } dpns = delegpt_find_ns(foriq->dp, qstate->qinfo.qname, qstate->qinfo.qname_len); if(!dpns) { diff --git a/services/listen_dnsport.c b/services/listen_dnsport.c index f0bec69a7..c6079008c 100644 --- a/services/listen_dnsport.c +++ b/services/listen_dnsport.c @@ -176,7 +176,7 @@ create_udp_sock(int family, int socktype, struct sockaddr* addr, *noproto = 1; else if(errno != EADDRINUSE) log_err("can't bind socket: %s", strerror(errno)); -#endif +#endif /* EADDRINUSE */ close(s); #else /* USE_WINSOCK */ if(WSAGetLastError() != WSAEADDRINUSE &&