From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 31 Mar 2025 22:36:27 +0000 (+0200)
Subject: expression: incorrect assert() list_expr_to_binop
X-Git-Tag: v1.1.2~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eebf7dd6582a2e94990388ba2d0772d14289b674;p=thirdparty%2Fnftables.git

expression: incorrect assert() list_expr_to_binop

assert() logic is reversed, all expressions in the list are handled,
including the first.

  src/expression.c:1285: list_expr_to_binop: Assertion `first' failed.

Fixes: 53d6bb992445 ("expression: initialize list of expression to silence gcc compile warning")
Reported-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/src/expression.c b/src/expression.c
index 9f19a379..dc9a4467 100644
--- a/src/expression.c
+++ b/src/expression.c
@@ -1282,7 +1282,7 @@ struct expr *list_expr_to_binop(struct expr *expr)
 		}
 	}
 	/* list with one single item only, this should not happen. */
-	assert(first);
+	assert(!first);
 
 	/* zap list expressions, they have been moved to binop expression. */
 	init_list_head(&expr->expressions);