From: Dan Carpenter Date: Sat, 12 Apr 2025 10:15:00 +0000 (+0300) Subject: gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() X-Git-Tag: v6.16-rc1~169^2~87 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eebfcb98cdc0228f5e1b7407f9db1c602bd8e545;p=thirdparty%2Fkernel%2Flinux.git gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() This code is intended to reject strings that start with "_sysfs" but the strcmp() limit is wrong so checks the whole string instead of the prefix. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter Reviewed-by: Geert Uytterhoeven Acked-by: Koichiro Den Link: https://lore.kernel.org/r/30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index dde969f29ee2b..b4c9e373a6ecb 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name) * for devices create via legacy sysfs interface. */ if (strncmp(name, AGGREGATOR_LEGACY_PREFIX, - sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0) + sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0) return ERR_PTR(-EINVAL); /* arg space is unneeded */