From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 2 Mar 2021 15:44:37 +0000 (+0200)
Subject: lib-smtp: Remove smtp_server_connection.disconnect_reason
X-Git-Tag: 2.3.15~254
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eee5cd271ab60470fbda1cc1685b0479a66e07b7;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: Remove smtp_server_connection.disconnect_reason

This isn't used anywhere and its purpose is a bit unclear.
---

diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c
index 5d3af14054..b5d7f7ff2b 100644
--- a/src/lib-smtp/smtp-server-connection.c
+++ b/src/lib-smtp/smtp-server-connection.c
@@ -1059,7 +1059,6 @@ smtp_server_connection_disconnect(struct smtp_server_connection *conn,
 	}
 
 	e_debug(conn->event, "Disconnected: %s", reason);
-	conn->disconnect_reason = i_strdup(reason);
 
 	/* Preserve statistics */
 	smtp_server_connection_update_stats(conn);
@@ -1122,7 +1121,6 @@ bool smtp_server_connection_unref(struct smtp_server_connection **_conn)
 
 	i_free(conn->helo_domain);
 	i_free(conn->username);
-	i_free(conn->disconnect_reason);
 	pool_unref(&conn->pool);
 	return FALSE;
 }
diff --git a/src/lib-smtp/smtp-server-private.h b/src/lib-smtp/smtp-server-private.h
index a635aab1b1..9c959b25fb 100644
--- a/src/lib-smtp/smtp-server-private.h
+++ b/src/lib-smtp/smtp-server-private.h
@@ -173,8 +173,6 @@ struct smtp_server_connection {
 	unsigned int command_queue_count;
 	unsigned int bad_counter;
 
-	char *disconnect_reason;
-
 	struct smtp_server_state_data state;
 
 	struct smtp_server_stats stats;