From: Eric Wong <e@80x24.org>
Date: Thu, 31 Mar 2016 03:39:06 +0000 (+0000)
Subject: repobrowse: avoid confusing linkification for "diff"
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ef0308fb20bc2f872aa5a8b115a19833224615a2;p=thirdparty%2Fpublic-inbox.git

repobrowse: avoid confusing linkification for "diff"

In /diff/ and /commit/ endpoints, making the word "diff"
a link to the top of the diff is not very useful and may
be confusing.  Avoid wasting bandwidth and overloading
the reader with potential options.
---

diff --git a/lib/PublicInbox/RepobrowseGitCommit.pm b/lib/PublicInbox/RepobrowseGitCommit.pm
index e250e346e..8fdbc47e9 100644
--- a/lib/PublicInbox/RepobrowseGitCommit.pm
+++ b/lib/PublicInbox/RepobrowseGitCommit.pm
@@ -243,7 +243,7 @@ sub git_diff_cc_hdr {
 	delete $req->{anchors}->{$anchor};
 	my $cc = $req->{cc} = PublicInbox::Hval->utf8($path);
 	$req->{path_cc} = $cc->as_path;
-	qq(<a\nhref=#D\nid="$anchor">diff</a> --$combined $html_path);
+	qq(<a\nid="$anchor">diff</a> --$combined $html_path);
 }
 
 # index abcdef09,01234567..76543210
diff --git a/lib/PublicInbox/RepobrowseGitDiffCommon.pm b/lib/PublicInbox/RepobrowseGitDiffCommon.pm
index 3b2cec6c5..9ed24d032 100644
--- a/lib/PublicInbox/RepobrowseGitDiffCommon.pm
+++ b/lib/PublicInbox/RepobrowseGitDiffCommon.pm
@@ -38,7 +38,7 @@ sub git_diff_ab_hdr ($$$) {
 
 	# not wasting bandwidth on links here
 	# links in hunk headers are far more useful with line offsets
-	qq(<a\nhref=#D\nid="$anchor">diff</a> --git $html_a $html_b);
+	qq(<a\nid="$anchor">diff</a> --git $html_a $html_b);
 }
 
 # @@ -1,2 +3,4 @@ (regular diff)