From: Hans de Goede Date: Thu, 4 Feb 2021 14:02:05 +0000 (+0100) Subject: platform/x86: acer-wmi: Don't use ACPI_EXCEPTION() X-Git-Tag: v5.12-rc1~123^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ef14f0e82c9b225ae19476fa5bed89d55b2a96d5;p=thirdparty%2Fkernel%2Flinux.git platform/x86: acer-wmi: Don't use ACPI_EXCEPTION() ACPI_EXCEPTION is only intended for internal use by the ACPICA code. ACPI_EXCEPTION was being used here to change the apci_status code into something human-readable, use acpi_format_exception() for this instead, which is the proper way to do this outside of ACPICA. Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20210204140205.268344-1-hdegoede@redhat.com --- diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index c1a5357da8857..85db9403cc14b 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -30,7 +30,6 @@ #include #include -ACPI_MODULE_NAME(KBUILD_MODNAME); MODULE_AUTHOR("Carlos Corbacho"); MODULE_DESCRIPTION("Acer Laptop WMI Extras Driver"); MODULE_LICENSE("GPL"); @@ -1605,7 +1604,8 @@ static void acer_kbd_dock_get_initial_state(void) status = wmi_evaluate_method(WMID_GUID3, 0, 0x2, &input_buf, &output_buf); if (ACPI_FAILURE(status)) { - ACPI_EXCEPTION((AE_INFO, status, "Error getting keyboard-dock initial status")); + pr_err("Error getting keyboard-dock initial status: %s\n", + acpi_format_exception(status)); return; }