From: Serge Hallyn <serge.hallyn@ubuntu.com>
Date: Mon, 15 Feb 2016 20:15:10 +0000 (-0800)
Subject: log.c:__lxc_log_set_file: fname cannot be null
X-Git-Tag: lxc-1.0.9~92
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ef1ba04cfacdc3f9e6dc0df02d571417a937703d;p=thirdparty%2Flxc.git

log.c:__lxc_log_set_file: fname cannot be null

fname cannot be passed in as NULL by any of its current callers.  If it
could, then build_dir() would crash as it doesn't check for it.  So make
sure we are warned if in the future we pass in NULL.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/log.c b/src/lxc/log.c
index 4796fe91e..948735d56 100644
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -20,6 +20,7 @@
  * License along with this library; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
+#include <assert.h>
 #include <stdio.h>
 #include <errno.h>
 #include <limits.h>
@@ -266,7 +267,9 @@ static int __lxc_log_set_file(const char *fname, int create_dirs)
 		free(log_fname);
 	}
 
-	if (!fname || strlen(fname) == 0) {
+	assert(fname != NULL);
+
+	if (strlen(fname) == 0) {
 		log_fname = NULL;
 		return 0;
 	}