From: Jim Meyering <jim@meyering.net>
Date: Mon, 24 Jan 2000 13:48:12 +0000 (+0000)
Subject: (main): Don't expect array index `n_files - 1' to evaluate
X-Git-Tag: FILEUTILS-4_0p~60
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=efa9563f3d0b78f1fe29654c9b197c3bd6412d97;p=thirdparty%2Fcoreutils.git

(main): Don't expect array index `n_files - 1' to evaluate
to `-1' for unsigned int n_files == 0.  Doing so lead to a segfault on
alpha.  From Michael Stone.
---

diff --git a/src/mv.c b/src/mv.c
index 3e1e6b96c1..71b4de8564 100644
--- a/src/mv.c
+++ b/src/mv.c
@@ -464,12 +464,8 @@ main (int argc, char **argv)
   file = argv + optind;
 
   target_directory_specified = (target_directory != NULL);
-  if (target_directory == NULL)
-    {
-      /* Be careful below.  When n_files is 0, this value will be
-	 argv[0], `--', or an option string.  */
-      target_directory = file[n_files - 1];
-    }
+  if (target_directory == NULL && n_files != 0)
+    target_directory = file[n_files - 1];
 
   dest_is_dir = (n_files > 0 && isdir (target_directory));