From: Alejandro Colomar <alx@kernel.org>
Date: Fri, 21 Apr 2023 09:29:12 +0000 (+0200)
Subject: EXIT_SUCCESS.3const: EXAMPLES: Do not use assignment in if condition
X-Git-Tag: man-pages-6.05~154
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=efbe9863a28dc094f40201c737a1a4927c062b5b;p=thirdparty%2Fman-pages.git

EXIT_SUCCESS.3const: EXAMPLES: Do not use assignment in if condition

Reported-by: checkpatch(1) (`make lint-c-checkpatch`)
Reported-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/man3const/EXIT_SUCCESS.3const b/man3const/EXIT_SUCCESS.3const
index fd3595f835..431f43bbb2 100644
--- a/man3const/EXIT_SUCCESS.3const
+++ b/man3const/EXIT_SUCCESS.3const
@@ -43,7 +43,8 @@ main(int argc, char *argv[])
         exit(EXIT_FAILURE);
     }
 
-    if ((fp = fopen(argv[1], "r")) == NULL) {
+    fp = fopen(argv[1], "r");
+    if (fp == NULL) {
         perror(argv[1]);
         exit(EXIT_FAILURE);
     }