From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 30 Oct 2025 00:18:24 +0000 (-0700)
Subject: Merge branch 'net-stmmac-hwif-c-cleanups'
X-Git-Tag: v6.19-rc1~170^2~283
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=efd3e30e651da21ac8a6bd83d24a92a948e1e7d3;p=thirdparty%2Fkernel%2Flinux.git

Merge branch 'net-stmmac-hwif-c-cleanups'

Russell King says:

====================
net: stmmac: hwif.c cleanups

This series cleans up hwif.c:

- move the reading of the version information out of stmmac_hwif_init()
  into its own function, stmmac_get_version(), storing the result in a
  new struct.

- simplify stmmac_get_version().

- read the version register once, passing it to stmmac_get_id() and
  stmmac_get_dev_id().

- move stmmac_get_id() and stmmac_get_dev_id() into
  stmmac_get_version()

- define version register fields and use FIELD_GET() to decode

- start tackling the big loop in stmmac_hwif_init() - provide a
  function, stmmac_hwif_find(), which looks up the hwif entry, thus
  making a much smaller loop, which improves readability of this code.

- change the use of '^' to '!=' when comparing the dev_id, which is
  what is really meant here.

- reorganise the test after calling stmmac_hwif_init() so that we
  handle the error case in the indented code, and the success case
  with no indent, which is the classical arrangement.
====================

Link: https://patch.msgid.link/aQFZVSGJuv8-_DIo@shell.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

efd3e30e651da21ac8a6bd83d24a92a948e1e7d3