From: Mark McLoughlin <markmc@redhat.com>
Date: Fri, 20 Nov 2009 18:13:10 +0000 (+0000)
Subject: slirp: fix use-after-free
X-Git-Tag: v0.11.1~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=efd4bd838d7b951a8eededfbfb56b73b49e746bc;p=thirdparty%2Fqemu.git

slirp: fix use-after-free

460fec67ee introduced a use-after free in slirp.

Cc: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---

diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 7652fea196f..87508ba0131 100644
--- a/slirp/mbuf.c
+++ b/slirp/mbuf.c
@@ -95,8 +95,8 @@ m_free(struct mbuf *m)
 	 * Either free() it or put it on the free list
 	 */
 	if (m->m_flags & M_DOFREE) {
-		free(m);
 		m->slirp->mbuf_alloced--;
+		free(m);
 	} else if ((m->m_flags & M_FREELIST) == 0) {
 		insque(m,&m->slirp->m_freelist);
 		m->m_flags = M_FREELIST; /* Clobber other flags */