From: Peter Geoghegan <pg@bowt.ie>
Date: Mon, 22 Apr 2024 02:51:56 +0000 (-0400)
Subject: Remove overzealous array element type assertion.
X-Git-Tag: REL_17_BETA1~190
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=eff6a757fde3ba072a03dd06edc2eafeac5e602d;p=thirdparty%2Fpostgresql.git

Remove overzealous array element type assertion.

This led to spurious assertion failures in certain scenarios involving
pseudo types.

Oversight in commit 5bf748b8, which enhanced nbtree ScalarArrayOp
execution.

Reported-By: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs48f5rDOwxaT76Zd40m7n9iGZQcjEk7vG_5p3YWNh6oPfA@mail.gmail.com
---

diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c
index ecbbc2466d2..8381027f4e5 100644
--- a/src/backend/access/nbtree/nbtutils.c
+++ b/src/backend/access/nbtree/nbtutils.c
@@ -392,7 +392,6 @@ _bt_preprocess_array_keys(IndexScanDesc scan)
 		elemtype = cur->sk_subtype;
 		if (elemtype == InvalidOid)
 			elemtype = rel->rd_opcintype[cur->sk_attno - 1];
-		Assert(elemtype == ARR_ELEMTYPE(arrayval));
 
 		/*
 		 * If the comparison operator is not equality, then the array qual