From: Gao Feng Date: Tue, 31 Oct 2017 10:25:37 +0000 (+0800) Subject: ppp: Destroy the mutex when cleanup X-Git-Tag: v4.15-rc1~84^2~201 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f02b2320b27c16b644691267ee3b5c110846f49e;p=thirdparty%2Fkernel%2Flinux.git ppp: Destroy the mutex when cleanup The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the good readbility, it's better to invoke it in exit func when the init func invokes mutex_init. Signed-off-by: Gao Feng Acked-by: Guillaume Nault Signed-off-by: David S. Miller --- diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index af7f93ed1487a..44891335f9afe 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -960,6 +960,7 @@ static __net_exit void ppp_exit_net(struct net *net) unregister_netdevice_many(&list); rtnl_unlock(); + mutex_destroy(&pn->all_ppp_mutex); idr_destroy(&pn->units_idr); }